Auditor: Avoid setting macOS rpaths for /workspace#1376
Auditor: Avoid setting macOS rpaths for /workspace#1376eschnett wants to merge 3 commits intoJuliaPackaging:masterfrom
Conversation
|
Please add a test. Which probably means removing BinaryBuilder.jl/test/auditing.jl Lines 695 to 696 in 2a5e711 |
|
The fact that tests are passing suggests this isn't doing much. |
|
My understanding of the issue is that the rpath isn't added by the auditor but it's already there at the end of the build, so skipping |
|
Probably this is also why this wasn't done before: unlike ELF files, we currently don't "update" the rpath list for Mach-O files, only add them if necessary. Which isn't the case here, there's nothing to add in the first place. |
|
Does the function |
|
The function you're modifying is adding new directories to rpath. The problem is that |
|
That bit I understood. Let me ask my question differently: How do I get the current list of rpaths in the library? Is there infrastructure for this, or would I be writing a bash script calling |
|
ObjectFile.jl (which is used in this package extensively) should be able to give you that. I don't remember on top of my head if there's any wrapper function. |
|
Bump. |
This addresses the first half of #1375, namely pruning
/workspacefrom rpaths.